From syshackmin at gmail.com  Tue Apr 14 21:36:44 2009
From: syshackmin at gmail.com (Dave Cundiff)
Date: Tue, 14 Apr 2009 15:36:44 -0400
Subject: [mpm-itk] New version of mpm-itk (2.2.11-01)
In-Reply-To: <20090321230111.GA7915@uio.no>
References: <20090321230111.GA7915@uio.no>
Message-ID: <5ebac9150904141236m33b70223te24783932fd6df41@mail.gmail.com>

On Sat, Mar 21, 2009 at 7:01 PM, Steinar H. Gunderson
<sgunderson at bigfoot.com> wrote:
>  * If waitpid() is interrupted by a signal (returning EINTR), try again.
>    This fixes a race condition where a graceful restart could fail and hang
>    the child forever. Adapted from patch by Jan Boysen, who also diagnosed and
>    reported the bug.

There's a problem with the bugfix. Its not actually trying again and
the old behavior is still present. The patch is supposed to try again
should waidpid error with EINTR. However, its checking for EINTR in
child_pid instead of errno. Patch below against latest itk and apache
2.2.11.


--- itk.c.bad   2009-04-14 15:29:32.000000000 -0400
+++ itk.c       2009-04-14 15:20:45.000000000 -0400
@@ -718,7 +718,7 @@
             default: /* parent; just wait for child to be done */
                 do {
                     child_pid = waitpid(pid, &status, 0);
-                } while (child_pid == -1 && child_pid == EINTR);
+                } while (child_pid == -1 && errno == EINTR);

                 if (child_pid != pid || !WIFEXITED(status)) {
                     if (WIFSIGNALED(status)) {



From sgunderson at bigfoot.com  Tue Apr 14 23:37:33 2009
From: sgunderson at bigfoot.com (Steinar H. Gunderson)
Date: Tue, 14 Apr 2009 23:37:33 +0200
Subject: [mpm-itk] New version of mpm-itk (2.2.11-01)
In-Reply-To: <5ebac9150904141236m33b70223te24783932fd6df41@mail.gmail.com>
References: <20090321230111.GA7915@uio.no>
	<5ebac9150904141236m33b70223te24783932fd6df41@mail.gmail.com>
Message-ID: <20090414213733.GA31630@samfundet.no>

On Tue, Apr 14, 2009 at 03:36:44PM -0400, Dave Cundiff wrote:
> There's a problem with the bugfix. Its not actually trying again and
> the old behavior is still present. The patch is supposed to try again
> should waidpid error with EINTR. However, its checking for EINTR in
> child_pid instead of errno. Patch below against latest itk and apache
> 2.2.11.

Yes, you're right. I'll make a new release which fixes this issue and
hopefully remedies most of the "permission denied" issues people have been
seeing.

/* Steinar */
-- 
Homepage: http://www.sesse.net/




From sgunderson at bigfoot.com  Tue Apr 14 23:57:20 2009
From: sgunderson at bigfoot.com (Steinar H. Gunderson)
Date: Tue, 14 Apr 2009 23:57:20 +0200
Subject: [mpm-itk] New version of mpm-itk (2.2.11-02)
Message-ID: <20090414215720.GA19414@samfundet.no>

Hi,

In response to a few bug reports against 2.2.11-01, I've released mpm-itk
2.2.11-02. It's very lightly tested, but all users of 2.2.11-01 are
recommended to upgrade.

>From the changelog:

  * Really fix the waitpid() code; thanks to Dave Cundiff for spotting the typo.
  * Add CAP_DAC_READ_SEARCH to the list of capabilities, so Apache can read
    .htaccess files that are not world readable. This should fix some of the
    "permission denied" problems that cropped up in 2.2.11-01, although you
    will still see the problem if you use root-squashed NFS.

Download is at http://mpm-itk.sesse.net/ as always. I've updated the Debian
packages already, so they should be ready for unstable in day or so.

/* Steinar */
-- 
Homepage: http://www.sesse.net/




From lampacz at gmail.com  Wed Apr 15 11:49:08 2009
From: lampacz at gmail.com (Lampa)
Date: Wed, 15 Apr 2009 11:49:08 +0200
Subject: [mpm-itk] New version of mpm-itk (2.2.11-02)
In-Reply-To: <20090414215720.GA19414@samfundet.no>
References: <20090414215720.GA19414@samfundet.no>
Message-ID: <9aef75b10904150249k5d00eb51tc324e56d2a724926@mail.gmail.com>

Hello,

why apache2-mpm-itk depends on libaprutil1-dbd-mysql,
libaprutil1-dbd-sqlite3, libaprutil1-dbd-odbc, libaprutil1-dbd-pgsql
or libaprutil1-dbd-freetds
apache2-mpm-itk depends on libaprutil1-ldap in debian testing amd64
(2.2.11-01-1+b1) in unstable is 2.2.6-02-1+b20


2009/4/14 Steinar H. Gunderson <sgunderson at bigfoot.com>:
> Hi,
>
> In response to a few bug reports against 2.2.11-01, I've released mpm-itk
> 2.2.11-02. It's very lightly tested, but all users of 2.2.11-01 are
> recommended to upgrade.
>
> From the changelog:
>
> ?* Really fix the waitpid() code; thanks to Dave Cundiff for spotting the typo.
> ?* Add CAP_DAC_READ_SEARCH to the list of capabilities, so Apache can read
> ? ?.htaccess files that are not world readable. This should fix some of the
> ? ?"permission denied" problems that cropped up in 2.2.11-01, although you
> ? ?will still see the problem if you use root-squashed NFS.
>
> Download is at http://mpm-itk.sesse.net/ as always. I've updated the Debian
> packages already, so they should be ready for unstable in day or so.
>
> /* Steinar */
> --
> Homepage: http://www.sesse.net/
>
>
> _______________________________________________
> mpm-itk mailing list
> mpm-itk at err.no
> http://lists.err.no/mailman/listinfo/mpm-itk
>



-- 
Lampa



From sgunderson at bigfoot.com  Wed Apr 15 12:21:44 2009
From: sgunderson at bigfoot.com (Steinar H. Gunderson)
Date: Wed, 15 Apr 2009 12:21:44 +0200
Subject: [mpm-itk] New version of mpm-itk (2.2.11-02)
In-Reply-To: <9aef75b10904150249k5d00eb51tc324e56d2a724926@mail.gmail.com>
References: <20090414215720.GA19414@samfundet.no>
	<9aef75b10904150249k5d00eb51tc324e56d2a724926@mail.gmail.com>
Message-ID: <20090415102144.GA28288@samfundet.no>

On Wed, Apr 15, 2009 at 11:49:08AM +0200, Lampa wrote:
> why apache2-mpm-itk depends on libaprutil1-dbd-mysql,
> libaprutil1-dbd-sqlite3, libaprutil1-dbd-odbc, libaprutil1-dbd-pgsql
> or libaprutil1-dbd-freetds
> apache2-mpm-itk depends on libaprutil1-ldap in debian testing amd64
> (2.2.11-01-1+b1) in unstable is 2.2.6-02-1+b20

Because apache2-mpm-prefork does. (You'll have to ask the main Apache
maintainers why prefork does, I have no idea.)

/* Steinar */
-- 
Homepage: http://www.sesse.net/